DGeom.isSpace()

CHANGELOG.md

@@ -29,11 +29,11 @@
     - [WARNING] bootstrap class path not set in conjunction with -source 8
       when using: mvn clean install -P on-jdk-9-plus
 - CI: Fail build on warning?!
-- Return dxGeom in public API -> WHere is the TODO???
 
 ## 0.5.0 (unreleased)
 
-- CHANGELOG.txt -> .md and added overview to README.md [#118](https://github.com/tzaeschke/ode4j/pull/118)
+- DGeom.isSpace() [#120](https://github.com/tzaeschke/ode4j/pull/120)
+- CHANGELOG.txt -> .md and added overview to README.md [#119](https://github.com/tzaeschke/ode4j/pull/119)
 - Cumulative fix:
     * Fixed missing call to Trimesh callbacks. [#76](https://github.com/tzaeschke/ode4j/issues/76)
     * Deprecated DTriArrayCallback. It was never supported and is considered for removal in ODE.

core/src/main/java/org/ode4j/ode/DGeom.java

@@ -316,12 +316,11 @@ public interface DGeom {
 	DAABBC getAABB ();
 
 
-//	/**
-//	 * Determing if a geom is a space.
-//	 * @param geom the geom to query
-//	 * @return Non-zero if the geom is a space, zero otherwise.
-//	 */
-	//	int isSpace();
+	/**
+	 * Determing if a geom is a space.
+	 * @return Non-zero if the geom is a space, zero otherwise.
+	 */
+	boolean isSpace();
 
 
 	/**
@@ -420,7 +419,7 @@ public interface DGeom {
 	 * that those pairs should not interact.
 	 */
 	//typedef void dNearCallback (void *data, dGeom o1, dGeom o2);
-	public interface DNearCallback {
+	interface DNearCallback {
 	    /**
 	     * @param data The user data object, as passed to dSpaceCollide.
 	     * @param o1   The first geom being tested.

core/src/main/java/org/ode4j/ode/internal/DxGeom.java

@@ -1863,8 +1863,8 @@ public DMatrix3C getRotation()
 	public void setQuaternion (DQuaternionC quat)
 	{ dGeomSetQuaternion (quat); }
 
-//	public int isSpace()
-//	{ return dGeomIsSpace (_id); }
+	public boolean isSpace()
+	{ return this instanceof DSpace; }
 
 	@Override
 	public void setCategoryBits (long bits)//unsigned long bits)

core/src/test/java/org/ode4j/ode/DGeomTest.java

@@ -0,0 +1,42 @@
+/*************************************************************************
+ *                                                                       *
+ * Open Dynamics Engine 4J, Copyright (C) 2009-2023 Tilmann Zaeschke     *
+ * All rights reserved.  Email: ode4j@gmx.de   Web: www.ode4j.org        *
+ *                                                                       *
+ * This library is free software; you can redistribute it and/or         *
+ * modify it under the terms of EITHER:                                  *
+ *   (1) The GNU Lesser General Public License as published by the Free  *
+ *       Software Foundation; either version 2.1 of the License, or (at  *
+ *       your option) any later version. The text of the GNU Lesser      *
+ *       General Public License is included with this library in the     *
+ *       file LICENSE.TXT.                                               *
+ *   (2) The BSD-style license that is included with this library in     *
+ *       the file ODE-LICENSE-BSD.TXT and ODE4J-LICENSE-BSD.TXT.         *
+ *                                                                       *
+ * This library is distributed in the hope that it will be useful,       *
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of        *
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the files    *
+ * LICENSE.TXT, ODE-LICENSE-BSD.TXT and ODE4J-LICENSE-BSD.TXT for more   *
+ * details.                                                              *
+ *                                                                       *
+ *************************************************************************/
+package org.ode4j.ode;
+
+import org.junit.Test;
+
+import static org.junit.Assert.*;
+
+public class DGeomTest {
+
+    /**
+     * DGeom::isSpace.
+     */
+    @Test
+    public void testIsSpace() {
+        DSpace space = OdeHelper.createSimpleSpace();
+        assertTrue(space.isSpace());
+
+        DBox box = OdeHelper.createBox(1, 1, 1);
+        assertFalse(box.isSpace());
+    }
+}