Adds new property namespace to index definitions
#325
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This property allows users to further isolate partition keys beyond just `service` participation. This implements an RFC that was thoughtfully put forward by [@sam3d](https://github.com/sam3d) in [Issue #290](#290).
✅ Deploy Preview for electrodb-dev ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
tywalch
changed the title
scope to index definitionsnamespace to index definitions
sam3d
reviewed
Nov 13, 2023
Yeah, I always try to sleep on things like this 😅 |
|
I read somewhere that sleep helps 😌 |
|
Btw I've just tested this PR, and it successfully replaces every single use of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This property allows users to further isolate partition keys beyond just
serviceparticipation. This implements an RFC that was thoughtfully put forward by @Sam3d in Issue #290.