Add Untainted qualifier. #58
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wmdietl
reviewed
Jun 23, 2020
| @@ -62,7 +63,7 @@ | |||
| * Constructs a new object. | |||
| */ | |||
| @HotSpotIntrinsicCandidate | |||
| public Object() {} | |||
| public @Untainted Object() {} | |||
There was a problem hiding this comment.
Should you also add tainting to @AnnotatedFor?
There was a problem hiding this comment.
No, all the methods have not been annotated, just this one.
There was a problem hiding this comment.
Our current suggestion is to fully annotate files: https://checkerframework.org/manual/#annotating-jdk
j.l.Object isn't very big, so wouldn't it be better to fully annotate it for the Tainting Checker?
The "Whenever you add a file" part no longer makes sense, as all possible files are already contained in the typetools/jdk repository.
There was a problem hiding this comment.
You should at least open an issue to keep track of this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge with typetools/checker-framework#2883.