Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New command-line option -AassumePureGetters #6302

Merged
merged 32 commits into from
Nov 14, 2023

Conversation

mernst
Copy link
Member

@mernst mernst commented Nov 12, 2023

Merge after #6295.

@mernst mernst mentioned this pull request Nov 12, 2023
Copy link
Member

@smillst smillst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just had one small comment.

return false;
}

// I could check that the method has a non-void return type.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You might as well do this. (Or just remove the comment.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's just deal with this in #6304.

@smillst smillst assigned mernst and unassigned smillst Nov 14, 2023
@smillst smillst merged commit a39302c into typetools:master Nov 14, 2023
29 checks passed
@smillst smillst deleted the getters-pure branch November 14, 2023 16:38
wmdietl pushed a commit to eisop/checker-framework that referenced this pull request Dec 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants