Checker allows Map.entry to take nulls.

[agentgt]

Checker seems to have no problem accepting:

Map.entry(null, null);

I figured it was because it was not annotated correctly so I tried a astub file of:

//Map.astub
package java.util;

import org.checkerframework.checker.nullness.qual.NonNull;

public interface Map<K, V> {
  // n.b. the parameters here are not from the interface
  public static <K, V> Entry<K, V> entry(@NonNull K k, @NonNull V v);
  // I also tried because DefaultQualifier cannot be put on stubs
  public static <@NonNull K, @NonNull V> Entry<@NonNull K, @NonNull V> entry(@NonNull K k, @NonNull V v);
}

[mernst]

With the stub file, is your problem resolved?

[agentgt]

No which is bizarre because I have other stub files. I tried testing that the stub file was being read by making Map.entry return @Nullable and that failed correctly (correctly by it did what it was told... obviously map.entry should not return nullable ... for others).

[smillst]

The following gives the expected warnings:

$ cat MapEntryNull.java
import java.util.Map;
import org.checkerframework.checker.nullness.qual.NonNull;

public class MapEntryNull {
  void m(){
    Map.entry(null,null);
  }
}

$ cat /Users/smillst/jsr308/testcases/src/Map.astub
package java.util;

 import org.checkerframework.checker.nullness.qual.NonNull;

 public interface Map<K, V> {
   public static <K, V> Entry<K, V> entry(@NonNull K k, @NonNull V v);
 }

$ javacheck -processor nullness MapEntryNull.java -Astubs=/Users/smillst/jsr308/testcases/src/Map.astub
MapEntryNull.java:6: error: [argument] incompatible argument for parameter k of Map.entry.
    Map.entry(null,null);
              ^
  found   : null (NullType)
  required: @Initialized @NonNull Object
MapEntryNull.java:6: error: [argument] incompatible argument for parameter v of Map.entry.
    Map.entry(null,null);
                   ^
  found   : null (NullType)
  required: @Initialized @NonNull Object
2 errors

[agentgt]

Here is my setup in Maven. I am using JDK 17.

    <profile>
      <id>checkerframework</id>
      <properties>
        <checkerframework.version>3.37.0</checkerframework.version>
      </properties>
      <build>
        <plugins>
          <plugin>
            <groupId>org.apache.maven.plugins</groupId>
            <artifactId>maven-compiler-plugin</artifactId>
            <configuration>
              <fork>true</fork>
              <compilerArgs combine.children="append">
                <arg>-Astubs=${parent.root}/etc/eea/checker</arg>
                <arg>-J--add-exports=jdk.compiler/com.sun.tools.javac.api=ALL-UNNAMED</arg>
                <arg>-J--add-exports=jdk.compiler/com.sun.tools.javac.code=ALL-UNNAMED</arg>
                <arg>-J--add-exports=jdk.compiler/com.sun.tools.javac.file=ALL-UNNAMED</arg>
                <arg>-J--add-exports=jdk.compiler/com.sun.tools.javac.main=ALL-UNNAMED</arg>
                <arg>-J--add-exports=jdk.compiler/com.sun.tools.javac.model=ALL-UNNAMED</arg>
                <arg>-J--add-exports=jdk.compiler/com.sun.tools.javac.processing=ALL-UNNAMED</arg>
                <arg>-J--add-exports=jdk.compiler/com.sun.tools.javac.tree=ALL-UNNAMED</arg>
                <arg>-J--add-exports=jdk.compiler/com.sun.tools.javac.util=ALL-UNNAMED</arg>
                <arg>-J--add-opens=jdk.compiler/com.sun.tools.javac.comp=ALL-UNNAMED</arg>
              </compilerArgs>
              <annotationProcessorPaths>
                <path>
                  <groupId>org.checkerframework</groupId>
                  <artifactId>checker</artifactId>
                  <version>${checkerframework.version}</version>
                </path>
              </annotationProcessorPaths>
              <annotationProcessors>
                <!-- Add all the checkers you want to enable here -->
                <annotationProcessor>org.checkerframework.checker.nullness.NullnessChecker</annotationProcessor>
              </annotationProcessors>
            </configuration>
          </plugin>
        </plugins>
      </build>
      <dependencies>
        <dependency>
          <groupId>org.checkerframework</groupId>
          <artifactId>checker</artifactId>
          <version>${checkerframework.version}</version>
        </dependency>
        <dependency>
          <groupId>org.checkerframework</groupId>
          <artifactId>checker-qual</artifactId>
          <version>${checkerframework.version}</version>
        </dependency>
      </dependencies>
    </profile>

I know checker works because it failed on other things and if change my Map.astub file to return @Nullable it fails.

Is my configuration wrong?

[agentgt]

Edit ok I copied and pasted @smillst stub and it works for me.

I have know idea why as mine was basically the same.

[agentgt]

We can probably close this. There must have been a strange cache issue. I still cannot understand how it could have possibly happened but I do have the Maven cache extension installed (but disabled).

[agentgt]

My apologies @mernst and @smillst on the incorrect bug. However I do think we should update typetools/jdk with the correct annotation right?

[smillst]

Thanks for reporting this and for the jdk pull request!