Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support switch expressions in the Resource Leak Checker #4993

Closed
msridhar opened this issue Dec 16, 2021 · 0 comments · Fixed by #5005
Closed

Support switch expressions in the Resource Leak Checker #4993

msridhar opened this issue Dec 16, 2021 · 0 comments · Fixed by #5005
Assignees
@msridhar

Comments

@msridhar
Copy link
Contributor

This will require some (hopefully modest) modifications to the MustCallConsistencyAnalyzer. Fortunately, there is already a synthetic variable for the value of each switch expression created during CFG construction. So I think all we will have to do is treat that variable as the "temporary" representing the switch expression, and everything else should work out.
@msridhar msridhar self-assigned this Dec 16, 2021
@msridhar msridhar mentioned this issue Jan 9, 2022
Merged
msridhar added a commit that referenced this issue Jan 10, 2022
@msridhar
Add support for switch expressions to Resource Leak Checker (#5005)
3a32eb1 
The only change required was to update temporary variable mappings, like we now do for ternary expressions.

Fixes #4993
wmdietl pushed a commit to eisop/checker-framework that referenced this issue Feb 1, 2022
@msridhar @wmdietl
Add support for switch expressions to Resource Leak Checker (typetool…
7a08207 
…s#5005)

The only change required was to update temporary variable mappings, like we now do for ternary expressions.

Fixes typetools#4993
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@msridhar msridhar

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add support for switch expressions to Resource Leak Checker msridhar/checker-framework
1 participant
@msridhar