-
Notifications
You must be signed in to change notification settings - Fork 507
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: update project tooling #376
Conversation
@@ -0,0 +1,8 @@ | |||
printWidth: 120 | |||
tabWidth: 2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This setting will create a big diff on the next PR, because most of the tabulations on the code is defined as 4 spaces. Should we change it now?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I know. I did not run prettier for this reason. We should clean up the PRs and only autoformat after.
LGTM. |
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This PR:
In a separate PR I also need to add some documentation about: