Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: missing type for field values on interface SearchResponseHit #213

Conversation

oliealex
Copy link
Contributor

@oliealex oliealex commented Jun 26, 2024

Change Summary

export interface SearchResponseHit<T extends DocumentSchema> interface is missing values.

Example of a response received.

highlights [
  {
    field: 'book',
    indices: [ 0 ],
    matched_tokens: [ [Array] ],
    snippets: [ '<em>book1</em>' ],
    values: [ '<em>book1</em>' ]
  }
]

PR Checklist

@oliealex oliealex changed the title fix: missing type values search response hit fix: missing type values on interface SearchResponseHit Jun 26, 2024
@oliealex oliealex changed the title fix: missing type values on interface SearchResponseHit fix: missing type for field values on interface SearchResponseHit Jun 26, 2024
@jasonbosco jasonbosco merged commit f7ba556 into typesense:master Jun 26, 2024
1 check passed
@jasonbosco
Copy link
Member

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants