feat(eslint-plugin): [no-this-alias] report on assignment expressions (…

…#4718)
typescript-eslint · Mar 29, 2022 · 8329498 · 8329498
1 parent 790a1ee
commit 8329498
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 4 deletions.
diff --git a/packages/eslint-plugin/src/rules/no-this-alias.ts b/packages/eslint-plugin/src/rules/no-this-alias.ts
@@ -48,11 +48,11 @@ export default util.createRule<Options, MessageIds>({
   ],
   create(context, [{ allowDestructuring, allowedNames }]) {
     return {
-      "VariableDeclarator[init.type='ThisExpression']"(
-        node: TSESTree.VariableDeclarator,
+      "VariableDeclarator[init.type='ThisExpression'], AssignmentExpression[right.type='ThisExpression']"(
+        node: TSESTree.VariableDeclarator | TSESTree.AssignmentExpression,
       ): void {
-        const { id } = node;
-
+        const id =
+          node.type === AST_NODE_TYPES.VariableDeclarator ? node.id : node.left;
         if (allowDestructuring && id.type !== AST_NODE_TYPES.Identifier) {
           return;
         }

diff --git a/packages/eslint-plugin/tests/rules/no-this-alias.test.ts b/packages/eslint-plugin/tests/rules/no-this-alias.test.ts
@@ -66,6 +66,13 @@ declare module 'foo' {
       code: 'const self = this;',
       errors: [idError],
     },
+    {
+      code: `
+let that;
+that = this;
+      `,
+      errors: [idError],
+    },
     {
       code: 'const { props, state } = this;',
       options: [