fix(eslint-plugin): [class-literal-property-style] don't report nodes…

… with `override` keyword (#10135) [class-literal-property-style] don't report nodes with `override` keyword
typescript-eslint · Oct 18, 2024 · 0cbd4cd · 0cbd4cd
1 parent 127066a
commit 0cbd4cd
Show file tree

Hide file tree

Showing 2 changed files with 31 additions and 1 deletion.
diff --git a/packages/eslint-plugin/src/rules/class-literal-property-style.ts b/packages/eslint-plugin/src/rules/class-literal-property-style.ts
@@ -146,6 +146,7 @@ export default createRule<Options, MessageIds>({
         MethodDefinition(node): void {
           if (
             node.kind !== 'get' ||
+            node.override ||
             !node.value.body ||
             node.value.body.body.length === 0
           ) {
@@ -223,7 +224,7 @@ export default createRule<Options, MessageIds>({
           }
         },
         PropertyDefinition(node): void {
-          if (!node.readonly || node.declare) {
+          if (!node.readonly || node.declare || node.override) {
             return;
           }
           const { properties } =

diff --git a/packages/eslint-plugin/tests/rules/class-literal-property-style.test.ts b/packages/eslint-plugin/tests/rules/class-literal-property-style.test.ts
@@ -257,6 +257,35 @@ class Mx {
       `,
       options: ['getters'],
     },
+    {
+      // https://github.com/typescript-eslint/typescript-eslint/issues/3602
+      // getter with override modifier should be ignored
+      code: `
+declare abstract class BaseClass {
+  get cursor(): string;
+}
+
+class ChildClass extends BaseClass {
+  override get cursor() {
+    return 'overridden value';
+  }
+}
+      `,
+    },
+    {
+      // https://github.com/typescript-eslint/typescript-eslint/issues/3602
+      // property with override modifier should be ignored
+      code: `
+declare abstract class BaseClass {
+  protected readonly foo: string;
+}
+
+class ChildClass extends BaseClass {
+  protected override readonly foo = 'bar';
+}
+      `,
+      options: ['getters'],
+    },
   ],
   invalid: [
     {