Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update swift tools version to 5.2 #297

Merged
merged 1 commit into from
Jun 15, 2020
Merged

Conversation

Zeta611
Copy link
Contributor

@Zeta611 Zeta611 commented Apr 29, 2020

What's in this pull request?

This updates swift tools version to 5.2.

Why merge this pull request?

This fixes #296. Without this fix, Xcode (from 11.4 and above) will resolve all the test dependencies of SwiftCheck as well: FileCheck.
This prevents Xcode from building previews for SwiftUI, essentially making SwiftUI unusable.

Swift Packages section of release note for Xcode 11.4:

Remote Swift packages with tools version 5.2 and above no longer resolve package dependencies that are only used in their test targets, improving performance and reducing the chance of dependency version conflicts. (56925017)

What's worth discussing about this pull request?

N/A

What downsides are there to merging this pull request?

N/A

@MaxDesiatov
Copy link

MaxDesiatov commented Jun 12, 2020

@CodaFi would you be able to review this PR? Otherwise, could you please point to anyone else in this org who could review it?

@sebastiangrail sebastiangrail merged commit abeeb22 into typelift:master Jun 15, 2020
@MaxDesiatov
Copy link

@sebastiangrail could you please also tag a new release with this change so that it could be used as a dependency?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Xcode canvas for SwiftUI always fail
3 participants