All dimensions were made to have implicit field equal to this.
#326
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows us to have nice implicit instance when `Dimension[Q]` is a companion object to some quantity.
buzden
force-pushed
the
make-dimensions-implicit
branch
from
660fd2e to
3149cd7
Compare
buzden
added a commit
to buzden/squants-cats
that referenced
this pull request
Nov 28, 2018
This is a dumb workarond of lack os implicitness of `Dimension[Q]` instances. Once typelevel/squants#320 is solved (e.g., typelevel/squants#326 is merged), there will be no need in such stuff.
buzden
force-pushed
the
make-dimensions-implicit
branch
from
3149cd7 to
d9018ca
Compare
|
This looks good to me, I'll wait for other committers to chime in before merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows us to have nice implicit instance when
Dimension[Q]is acompanion object to some quantity.
This solves #320 and allows e.g. to write a single cats'
Monoid(or evenCommutativeGroup) instance for all quantities (i.e. to havedef groupInstance[Q <: Quantity[Q]: Dimension]: Group[Q]or so).