Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add units of measure: mm/s (velocity), mm/s^2 (acceleration), ng (mass) #290

Merged
merged 3 commits into from
Dec 19, 2017

Conversation

psung
Copy link
Contributor

@psung psung commented Dec 19, 2017

These units give the next smaller SI prefix than what is currently available for velocity, acceleration, and mass.

Phil Sung added 3 commits December 18, 2017 17:18
For uniformity, also add the implicit conversion Double.micrograms (synonymous
with Double.mcg).
Also add a missing test for v.toKilometersPerSecond.
@psung
Copy link
Contributor Author

psung commented Dec 19, 2017

FYI, we have uses for all of these units internally, but I don't know what squants's general policy is on having derived units that only differ in an SI prefix from some existing unit. For example, I'd completely understand if you decide you don't want to have to pave the way, for, say, having every unit of acceleration from NanometersPerSecondSquared to KilometersPerSecondSquared, or whatever. So feel free to only accept all/some/none of these changes; in the branch I've separated each of the new units into a separate commit.

@derekmorr
Copy link
Collaborator

This looks good to me. Thanks for adding these.

@derekmorr derekmorr merged commit e47b493 into typelevel:master Dec 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants