Mass electron volt #275
Merged
Mass electron volt #275
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cquiroz
force-pushed
the
mass-electron-volt
branch
from
1d4f113 to
b3f1904
Compare
derekmorr
reviewed
Jun 27, 2017
| @@ -171,6 +182,45 @@ object SolarMasses extends MassUnit { | |||
| val symbol = "M☉" | |||
| } | |||
|
|
|||
| object ElectronVolt extends MassUnit { | |||
There was a problem hiding this comment.
Won't this cause name collisions in the REPL since we import all constants and implicits by default?
There was a problem hiding this comment.
This is problematic in general. Having the same name will create problems either on the REPL or other cases. I'm kind of leaning to use ElectronVolt for Energy and use something like ElectronVoltMass in this case and similar
What do you think?
cquiroz
force-pushed
the
mass-electron-volt
branch
2 times, most recently
from
90ba512 to
e6a9cd9
Compare
cquiroz
force-pushed
the
mass-electron-volt
branch
from
e6a9cd9 to
823d677
Compare
|
I renamed the unit to |
derekmorr
approved these changes
Jul 11, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds electron volt as a
Massunit.A possible problem here is that there are
ElectronVoltunits for different quantities and there could be some conflicts if you were going to import bothEnergyandMass. They are different units but use the same name in the common usage