Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Permeability #271

Merged
merged 6 commits into from
Jul 8, 2017
Merged

Permeability #271

merged 6 commits into from
Jul 8, 2017

Conversation

cquiroz
Copy link
Collaborator

@cquiroz cquiroz commented Jun 20, 2017

While looking at the universal constants #257 I realized that we don't have a definition for Permeability. This PR adds this new Quantity

@nvinuesa
Copy link
Contributor

Maybe we should standardize what to do with "symbol". In some clases it is a val, in others it is a def.
@cquiroz @derekmorr

@cquiroz
Copy link
Collaborator Author

cquiroz commented Jun 21, 2017

@underscorenico That's a good observation. I'd venture to say that in most cases a val is appropriate. I'll change the code to reflect that

@cquiroz cquiroz force-pushed the magnetic-permeability branch 4 times, most recently from 471b951 to 4b47bab Compare June 27, 2017 02:39
@nvinuesa
Copy link
Contributor

@cquiroz I was thinking that you could also implement the / method in Inductance, which returns Permeability.

@cquiroz
Copy link
Collaborator Author

cquiroz commented Jun 28, 2017

@underscorenico Good suggestion, I added the division and also added multiplication to Permeability to get Inductance

@cquiroz
Copy link
Collaborator Author

cquiroz commented Jul 7, 2017

How can we move forward on this and the other pending PRs?

Copy link
Collaborator

@derekmorr derekmorr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cquiroz cquiroz merged commit cbabfe7 into typelevel:master Jul 8, 2017
@cquiroz cquiroz deleted the magnetic-permeability branch July 8, 2017 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants