Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add ElectricCurrentDensity and MagneticFieldStrength types #269

Merged
merged 1 commit into from
Jun 25, 2017
Merged

add ElectricCurrentDensity and MagneticFieldStrength types #269

merged 1 commit into from
Jun 25, 2017

Conversation

nvinuesa
Copy link
Contributor

3rd PR concerning #252 .
This PR assesses unimplemented methods in ElectricCurrent and adds needed types.

@derekmorr
Copy link
Collaborator

Could you be sure to update the ImplicitDimension object with this?

@nvinuesa
Copy link
Contributor Author

Oh sorry, I did it again

@nvinuesa
Copy link
Contributor Author

Done!
I also added ElectricCurrent, which was missing

@derekmorr
Copy link
Collaborator

Thanks! I'll take a look at these over the weekend.

@nvinuesa
Copy link
Contributor Author

Corrected unit names, added "per". Symbol is now val instead of def

@derekmorr derekmorr modified the milestone: 1.4 Jun 25, 2017
@derekmorr derekmorr merged commit ffca49d into typelevel:master Jun 25, 2017
@nvinuesa nvinuesa deleted the issue-252-3 branch July 25, 2017 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@derekmorr derekmorr derekmorr approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
1.4
Development

Successfully merging this pull request may close these issues.
2 participants
@nvinuesa @derekmorr