Mark Ops traits as Serializable #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 29, 2020
Codecov Report
@@ Coverage Diff @@
## master #29 +/- ##
=======================================
Coverage 79.76% 79.76%
=======================================
Files 9 9
Lines 336 336
Branches 6 6
=======================================
Hits 268 268
Misses 68 68
Continue to review full report at Codecov.
|
larsrh
approved these changes
May 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
Opstraits generated by Simulacrum have never been markedSerializable, which can cause problems on Spark. We could make this an option but right now that seems like unnecessary complexity.The important part here is adding
Serializableto theOpstraits. I've also done theToXOpsones for consistency, but I'm hoping we can deprecate them soon anyway.