Add more options #142
Open
Add more options #142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -41,6 +41,9 @@ private[scalacoptions] trait ScalacOptions { | |||
| ): ScalacOption = | |||
| ScalacOption(option, args, isSupported) | |||
|
|
|||
| /** Set the encoding to UTF-8 */ | |||
| val encodingUTF8 = encoding("utf8") | |||
There was a problem hiding this comment.
I'm not sure including this option is necessary, We already include utf encoding in default options:
There was a problem hiding this comment.
Just because it's widely used with UTF-8, I've always seen this setting set with UTF-8
| @@ -157,6 +166,10 @@ private[scalacoptions] trait ScalacOptions { | |||
| val languageStrictEquality = | |||
| languageFeatureOption("strictEquality", version => version >= V3_0_0) | |||
|
|
|||
| /** Enable dynamics support. */ | |||
There was a problem hiding this comment.
I'm also wondering is this worth adding, dynamics seems not a popular choice and it's not too much hassle to use languageFeatureOption("dynamics") directly.
There was a problem hiding this comment.
I'm using it in some project and I though i'd be useful - If isn't we can remove it, np
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds:
indentTurn on bracket-less styleno-indentTurn off bracket-less stylelanguageDynamicsEnable dynamics support.encodingUTF8Set the encoding to UTF-8