Clean up sbt plugins #336
Clean up sbt plugins #336
Conversation
js/src/main/scala/mouse/js.scala
Outdated
| @@ -1,3 +1,24 @@ | |||
| /* | |||
| * Copyright (c) 2022 Typelevel | |||
There was a problem hiding this comment.
@benhutchison the sbt-typelevel plugin is bundled with the sbt-header plugin, so that's why headers have been generated. The difference with LICENSE.txt is that the copyright belongs to Typelevel. So we should change that belonging in LICENSE.txt or for all files, for consistency. What do you think about that?
There was a problem hiding this comment.
Happy to ascribe copyright to Typelevel in LICENSE.txt 👍
| override def eqv(x: MalformedURLException, y: MalformedURLException): Boolean = | ||
| x.getMessage == y.getMessage | ||
| } | ||
|
|
||
| assertEquals( |
There was a problem hiding this comment.
Just curious how this change comes into it.. is Eq[URL] supported out of the box now or something?
There was a problem hiding this comment.
It seems it was unused after migration to MUnit. assertEquals isn't integrated with cats.Eq.
|
@benhutchison Thank you for your review! |
This PR includes:
sbt-typelevelplugin;sbt-typelevelplugin. Due to new compiler settings - every warning at the CI became fatal. And I think that is pretty good.