Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update nscplugin, sbt-scala-native, ... to 0.4.12 #736

Merged
merged 1 commit into from
Mar 24, 2023

Conversation

typelevel-steward[bot]
Copy link
Contributor

Updates

from 0.4.10 to 0.4.12.
GitHub Release Notes - Version Diff

I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.

If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.

Configure Scala Steward for your repository with a .scala-steward.conf file.

Have a fantastic day writing Scala!

Adjust future updates

Add this to your .scala-steward.conf file to ignore future updates of this dependency:

updates.ignore = [ { groupId = "org.scala-native" } ]

Or, add this to slow down future updates of this dependency:

dependencyOverrides = [{
  pullRequests = { frequency = "30 days" },
  dependency = { groupId = "org.scala-native" }
}]

labels: library-update, early-semver-minor, semver-spec-patch, commit-count:1

Copy link
Member

@danicheg danicheg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@armanbilge so, 0.4.12 also isn't forward-compatible, right?

@armanbilge
Copy link
Member

armanbilge commented Mar 23, 2023

@danicheg in general, Scala Native bumps are not forward-compatible. E.g. a bump from 0.4.11 to 0.4.12 should be treated equivalent to a Scala bump from 3.2.2 to 3.3.0 or a Scala.js bump from 1.13.0 to 1.14.0.

Actually, it's the same as as how http4s 0.23.19 is not forward-compatible with 0.23.18. It's the exact same versioning model :)

@danicheg
Copy link
Member

Scala bump from 3.2.2 to 3.3.0

Hmm, I thought they planned to fix it, but okay

Actually, it's the same as as how http4s 0.23.19 is not forward-compatible with 0.23.18. It's the exact same versioning model :)

Sure, but http4s is not a "language"

@armanbilge
Copy link
Member

Hmm, I thought they planned to fix it, but okay

https://www.scala-lang.org/blog/2022/08/17/long-term-compatibility-plans.html

Sure, but http4s is not a "language"

Neither is Scala Native, really. It's all one Scala language, just different backends for the compiler. But I agree these things are very difficult to compare.

Anyway, ftr I have no opposition to this merging. Scala Native is still not as stable as Scala.js, so the assumption is users are aware of the risks. Sometimes I wait to merge stuff if I already know about some regressions, but it's not the end of the world.

@danicheg
Copy link
Member

Some of the upstreams have already merged this. Also, we have a convincing comment from Arman above. So, let's move on.

@danicheg danicheg merged commit ffc73c0 into main Mar 24, 2023
@danicheg danicheg deleted the update/nscplugin-0.4.12 branch March 24, 2023 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants