Backport LoggerFactory to 1.x series #656
Conversation
The reasoning for this commit is that I want to avoid having a Sync instance just for being able to log in a http4s api. Extract LoggerName from macro and make it an implicit. This makes it easier to have forwarders to Slf4jLogger. This should be binary compatible, I had to add some exclusions to mima because of the missing macro methods.
* Extract Platform traits for different code * LoggerName moved to shared * LoggerFactory with convenience methods.
* Extracted LoggerFactory and LoggerFactoryGen * Moved LoggerName to core and added macro there * Renamed Platform traits to Compat traits * Moved Slf4jLoggerFactory into Sl4j4Logger.Factory trait
This reverts commit 7167e54.
|
This seems good to me, but I don't see that CI ran, nor do I see a place to approve a run for a first-time contributor. 🤔 |
|
I added my own commit, and that triggered something that will check the rest. |
|
Okay, looks like we've got binary compatibility issues. Seems like we would have hard to sort these out in 2.x. I don't have time to chase it, but happy to review it if @FunFunFine or someone else can green it up. |
core/shared/src/main/scala/org/typelevel/log4cats/LoggerFactory.scala
Outdated
Show resolved
Hide resolved
|
@FunFunFine Anton, let me know if you need help with Mima's issues. |
…y.scala Co-authored-by: Daniel Esik <e.danicheg@yandex.ru>
danicheg
force-pushed
the
series/1.x-backport-logger-factory
branch
2 times, most recently
from
8edfafc to
290c72c
Compare
danicheg
force-pushed
the
series/1.x-backport-logger-factory
branch
from
290c72c to
ac8a327
Compare
|
I think I beat the final boss. @rossabaker you have done huge work on reviewing this. It'd be cool if you do it once again. |
|
Thank you guys for taking this, I had quite a tough couple of weeks at work, so you really helped me (and library users). |
|
This is being released as 1.7.0. |
See #655
This MR backports #629 to Cats-Effect 2 compatible release series.