Add LoggerFactory.mapK #653
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danicheg
reviewed
May 19, 2022
core/shared/src/main/scala/org/typelevel/log4cats/LoggerFactory.scala
Outdated
Show resolved
Hide resolved
|
Maybe slightly redundant but I've added a compilation check like the LoggerSyntaxCompilation |
ChristopherDavenport
approved these changes
May 19, 2022
|
This is exactly what I need, thank you! When might we see this included in a new release? |
|
Oh, we really didn't release this. I think it'd be fine to do a new patch release |
|
@kierendavies And it's done. Our Steward is already asking to bump to |
|
Thank you ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've been playing around with Natchez and natchez-extras-log4cats. This proved to be a required step to use LoggerFactory rather than instantiating a Kleisli logger and passing around explicitly/implicitly.
I would have applied this to LoggerFactoryGen but with the override type I struggled, I think you would need to lift it into the typeclass signature, but suggestions welcome.