Add fluent combinators for adding context to structured loggers #425
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #424
addContext(Map[String, String])
members are trivial wrappers over existingwithContext
functions. I couldn't call thiswithContext
because for some reason that disabled static forwarders forStructuredLogger.withContext
etc., which broke binary compatibility. 🤷 Thankfully, I like the new name better than the old one, because it makes it clear that the context is appended rather than replaced.addContext((String, Shown)*)
is sugar over it using theShow.Shows
magnet. Consider:We can add similar sugar for
error
,info
etc. - but I'm not sure those would be useful enough to justify the required explosion of the number of methods.