Add a LogLevel.fromString method
#343
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I would prefer that we match the output of And for the sake of not breaking the existing API I think it's best to adapt your method. Otherwise I wouldn't care either way. Also, just remembered I'm a maintainer of this repo 😬 |
|
That's reasonable. Feel free to edit this branch before merging if I don't get to it first |
I have this in my codebase, figured it makes sense to push upstream. Do we want it to match the output of `show` at all?
lorandszakacs
force-pushed
the
patch-1
branch
from
432c197 to
56fc3a1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have this in my codebase, figured it makes sense to push upstream.
Do we want it to match the output of
showat all?