-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix for polymorphic fields in SqlMapping #634
Conversation
d1132ce
to
d843eff
Compare
Can you summarize what this change does? It looks like it's causing all of our discriminator predicates to fail. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 this is working fine for us. The problem was on our end and was related to one of the new static methods on ResultT
, for which we had a local syntax method with a different type (everything continued to typecheck after the update but some database operations were no longer being executed)
@tpolecat thanks for the update! |
7c15071
to
f2cbc4b
Compare
Rebased. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #634 +/- ##
==========================================
+ Coverage 74.22% 75.59% +1.36%
==========================================
Files 32 32
Lines 4609 5064 +455
Branches 1025 1099 +74
==========================================
+ Hits 3421 3828 +407
- Misses 1188 1236 +48 ☔ View full report in Codecov by Sentry. |
+ The resolution of polymorphic field mappings now takes the runtime context into account properly. + All narrowing operations on cursors yield a value in Result allowing mappings to report internal errors for failed discriminators. + In SQL mappings, failed discriminators now fail the entire query with an internal error. + The TypeCase extractor has been removed because it can't take the context into account.
a1dbc5f
to
6f5a7dd
Compare
Result
allowing mappings to report internal errors for failed discriminators.TypeCase
extractor has been removed because it can't take the context into account.