Stream - microptimise EvalTap #3196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diesalbla
force-pushed
the
evalTap_optimise
branch
2 times, most recently
from
dde708d to
b0152f0
Compare
armanbilge
reviewed
Apr 2, 2023
diesalbla
force-pushed
the
evalTap_optimise
branch
from
fe53bc4 to
984e937
Compare
armanbilge
approved these changes
Apr 2, 2023
armanbilge
reviewed
Apr 2, 2023
diesalbla
force-pushed
the
evalTap_optimise
branch
from
984e937 to
bb294dd
Compare
Expand the implementation of evalMap inside evalTap. Instead of making the `as` call in the underlying effect `F`, we can just use the Pull `>>` sequencing operator, to ignore the result of running the action. For binary compatibility we keep an old version without the implicit. Co-authored-by: Arman Bilge <armanbilge@gmail.com>
diesalbla
force-pushed
the
evalTap_optimise
branch
from
bb294dd to
f96c01d
Compare
armanbilge
approved these changes
Apr 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expand the implementation of evalMap inside evalTap. Instead of making the
ascall in the underlying effectF, we can just use the Pull>>sequencing operator, to ignore the result of running the action.