Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use UndefOr for Node.js file Flags not supported on windows #3127

Merged
merged 1 commit into from
Feb 7, 2023
Merged

Use UndefOr for Node.js file Flags not supported on windows #3127

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions io/js/src/main/scala/fs2/io/file/Flag.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,8 +40,8 @@ object Flag extends FlagCompanionApi {
val Create = Flag(facade.fs.constants.O_CREAT)
val CreateNew = Flag(facade.fs.constants.O_CREAT.toLong | facade.fs.constants.O_EXCL.toLong)

val Sync = Flag(facade.fs.constants.O_SYNC)
val Dsync = Flag(facade.fs.constants.O_DSYNC)
val Sync = Flag(facade.fs.constants.O_SYNC.getOrElse(0.0))
val Dsync = Flag(facade.fs.constants.O_DSYNC.getOrElse(0.0))

private[file] implicit val monoid: Monoid[Flag] = new Monoid[Flag] {
override def combine(x: Flag, y: Flag): Flag = Flag(x.bits | y.bits)
Expand Down
6 changes: 4 additions & 2 deletions io/js/src/main/scala/fs2/io/internal/facade/fs.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,9 +118,11 @@ package fs {

val O_EXCL: Double = js.native

val O_SYNC: Double = js.native
// UndefOr, because windows (:

val O_DSYNC: Double = js.native
val O_SYNC: js.UndefOr[Double] = js.native

val O_DSYNC: js.UndefOr[Double] = js.native

}

Expand Down