Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Scope#interruptWhen error #2634

Merged
merged 1 commit into from
Sep 28, 2021
+3 −1
Merged

Improve Scope#interruptWhen error #2634

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Improve Scope#interruptWhen error
@rossabaker
rossabaker committed Sep 27, 2021
commit 4b0ff276c9bf924e3007572d30e228ce635d4291
4 changes: 3 additions & 1 deletion core/shared/src/main/scala/fs2/internal/Scope.scala
View file
Original file line number Diff line number Diff line change
@@ -397,7 +397,9 @@ private[fs2] final class Scope[F[_]] private (
interruptible match {
case None =>
F.raiseError(
new IllegalStateException("Scope#interrupt called for Scope that cannot be interrupted")
new IllegalStateException(
"Scope#interruptWhen called for Scope that cannot be interrupted. This can happen when a Stream uses Concurrent operations but is compiled with only a Sync constraint."
)
)
case Some(iCtx) =>
val outcome: F[InterruptionOutcome] = haltWhen.map(