Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix UnixSockets classpath detection logic #2624

Merged

Conversation

mpilquist
Copy link
Member

Fixes #2623

Copy link
Member

@armanbilge armanbilge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we care enough to add any sort of regression tests?

@mpilquist
Copy link
Member Author

I don't know how we could do that. Good news is that http4s build will validate this though.

@armanbilge
Copy link
Member

Can't we do CI for fs2 on older JDKs? It's only UnixSockets that needs JDK 16 right, and this is specifically what we'd want to test?

@vasilmkd
Copy link
Member

It complicates the build with two JDKs, one for building, one for running.

@armanbilge
Copy link
Member

Yeah, now that its being tested downstream probably more trouble than it's worth.

@mpilquist
Copy link
Member Author

Yeah, not sure what that build would even look like. If we tried just running the same test suite on a different JDK, then SBT will recompile everything. We'd have to somehow publish artifacts somewhere and then run a completely different SBT project using those artifacts.

@armanbilge
Copy link
Member

We'd have to somehow publish artifacts somewhere and then run a completely different SBT project using those artifacts.

Aren't the artifacts already pushed into GHA cache?

@mpilquist
Copy link
Member Author

Yes but SBT will notice the JDK changed and invalidate them / rebuild them.

@mpilquist mpilquist merged commit ac66d9b into typelevel:main Sep 20, 2021
@mpilquist mpilquist deleted the topic/fix-unix-sockets-detection branch February 18, 2024 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UnixSockets throws a NoClassDefFoundError when used on JDK15 or prior
5 participants