-
Notifications
You must be signed in to change notification settings - Fork 607
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix UnixSockets classpath detection logic #2624
Fix UnixSockets classpath detection logic #2624
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we care enough to add any sort of regression tests?
I don't know how we could do that. Good news is that http4s build will validate this though. |
Can't we do CI for fs2 on older JDKs? It's only UnixSockets that needs JDK 16 right, and this is specifically what we'd want to test? |
It complicates the build with two JDKs, one for building, one for running. |
Yeah, now that its being tested downstream probably more trouble than it's worth. |
Yeah, not sure what that build would even look like. If we tried just running the same test suite on a different JDK, then SBT will recompile everything. We'd have to somehow publish artifacts somewhere and then run a completely different SBT project using those artifacts. |
Aren't the artifacts already pushed into GHA cache? |
Yes but SBT will notice the JDK changed and invalidate them / rebuild them. |
Fixes #2623