Stream - GroupWithin - Some changes. #2619
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diesalbla
force-pushed
the
groupWithin_refactor
branch
2 times, most recently
from
33f401b to
21e1d63
Compare
- Rename the `n` parameter as `chunkSize` - For `dequeueN` and other internal functions, no need to pass the `n` parameter since that is just the `outputSize` parameter of main function. - Extract auxiliary `toEnding` function, exit-case to unit or error.
diesalbla
force-pushed
the
groupWithin_refactor
branch
from
21e1d63 to
2634b71
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
nparameter asoutputSizedequeueNand other internal functions, no need to pass thenparameter since that is just theoutputSizeparameter of main function.toEndingfunction.