Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove optimized Stream.map due to leaky implementation #2572

Merged
merged 4 commits into from
Aug 24, 2021
+32 −55
Merged

Remove optimized Stream.map due to leaky implementation #2572

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
cf77a31
Remove optimized implementation of map due to memory leak
mpilquist Aug 24, 2021
d93b035
Scalafmt
mpilquist Aug 24, 2021
28c795b
Fix failing resourceWeak test
mpilquist Aug 24, 2021
404c813
Adjust mima exclusions
mpilquist Aug 24, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Scalafmt
@mpilquist
mpilquist committed Aug 24, 2021
commit d93b03553ac272a0dbc4c074b2822aa796422d44
10 changes: 5 additions & 5 deletions core/shared/src/main/scala/fs2/Pull.scala
View file
Original file line number Diff line number Diff line change
@@ -1187,11 +1187,11 @@ object Pull extends PullLowPriority {
val result = Succeeded(scope.asInstanceOf[y])
go(scope, extendedTopLevelScope, translation, runner, view(result))

case eval: Eval[G, r] => goEval[r](eval, view)
case acquire: Acquire[G, y] => goAcquire(acquire, view)
case inScope: InScope[g, _] => goInScope(inScope.stream, inScope.useInterruption, view)
case int: InterruptWhen[g] => goInterruptWhen(translation(int.haltOnSignal), view)
case close: CloseScope => goCloseScope(close, view)
case eval: Eval[G, r] => goEval[r](eval, view)
case acquire: Acquire[G, y] => goAcquire(acquire, view)
case inScope: InScope[g, _] => goInScope(inScope.stream, inScope.useInterruption, view)
case int: InterruptWhen[g] => goInterruptWhen(translation(int.haltOnSignal), view)
case close: CloseScope => goCloseScope(close, view)
}
case _: Succeeded[_] => runner.done(scope)
case failed: Fail => runner.fail(failed.error)