Rework parJoin to work with transformers
#2552
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vasilmkd
force-pushed
the
parjoin
branch
2 times, most recently
from
123c032 to
16477dd
Compare
|
Was there any reason not to merge this one? We've already merged the equivalent PR on main, right? |
|
No reason really, the tests pass and the leak tests are fine too. I think it wasn't properly reviewed is all. |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1945.
The memory leak tests seem happy, I ran the CI many times yesterday and this morning.
I will follow this up with a PR that fixes this issue on
main. It should be even simpler given that Cats Effect 3 has support for theOutcomeinguaranteeCase, which we can use to sequence short-circuiting monad transformers.