PipedStreamBuffer bug fix port #2459
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diesalbla
approved these changes
Jul 3, 2021
Comment on lines
+185
to
+196
| src | ||
| .through(text.utf8Decode) | ||
| .foldMonoid | ||
| .flatMap { expected => | ||
| src | ||
| .through(test(chunkSize)) | ||
| .through(text.utf8Decode) | ||
| .foldMonoid | ||
| .evalMap { actual => | ||
| IO(assertEquals(actual, expected)) | ||
| } | ||
| } |
There was a problem hiding this comment.
Suggested change
| src | |
| .through(text.utf8Decode) | |
| .foldMonoid | |
| .flatMap { expected => | |
| src | |
| .through(test(chunkSize)) | |
| .through(text.utf8Decode) | |
| .foldMonoid | |
| .evalMap { actual => | |
| IO(assertEquals(actual, expected)) | |
| } | |
| } | |
| val actual = text.utf8Decode(test(chunkSize)(src)).foldMonoid | |
| val expectedS = text.utf8Decode(src).foldMonoid | |
| expectedS.flatMap { expected => | |
| actualS.evalMap { actual => | |
| IO(assertEquals(actual, expected)) | |
| } | |
| } |
Also, on a quick glance, can we compile both the expected and the actual stream?
|
Feel free to adjust tests in subsequent PR. Going to merge this in preparation for a 3.0.6 release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #2457 for fs2 3.0.
Again, sorry for this whole mess.