Set MIMA plugin for the project #560
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pomadchin
commented
Sep 4, 2021
build.sbt
Outdated
| @@ -19,6 +21,7 @@ lazy val root = Project("frameless", file("." + "frameless")).in(file(".")) | |||
| .aggregate(core, cats, dataset, ml, docs) | |||
| .settings(framelessSettings: _*) | |||
| .settings(noPublishSettings: _*) | |||
| .settings(mimaPreviousArtifacts := Set(), mimaFailOnNoPrevious := false) | |||
There was a problem hiding this comment.
To skip mimaReportBinaryIssues command in the root and mdocs sub projects.
…ests pass first even the changes are breaking)
pomadchin
force-pushed
the
feature/mima-plugin
branch
from
f43127c to
71dd24e
Compare
Codecov Report
@@ Coverage Diff @@
## master #560 +/- ##
=======================================
Coverage 96.28% 96.28%
=======================================
Files 61 61
Lines 1051 1051
Branches 5 5
=======================================
Hits 1012 1012
Misses 39 39
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
cchantep
approved these changes
Sep 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR sets the MIMA plugin for the project to catch binary compatability issues.
It adds a nextra CI step. For the manual test it is possible to run the binary compatibility check via the
mimaReportBinaryIssuessbt command.Closes #559