Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated readme for 0.5.0 release [Last PR before releasing 0.5.0] #249

Merged
merged 1 commit into from
Feb 18, 2018

Conversation

imarios
Copy link
Contributor

@imarios imarios commented Feb 12, 2018

Hey @adelbertc and @OlivierBlanvillain. I would love to have your take on my proposed changes for the landing page. Thanks!

Here is the link to my branch in case you want to see how it renders:
https://github.com/imarios/frameless/tree/update_readme_0.5

Copy link
Contributor

@adelbertc adelbertc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

@imarios imarios force-pushed the update_readme_0.5 branch 3 times, most recently from 089b635 to a4d3765 Compare February 13, 2018 04:59
@codecov-io
Copy link

Codecov Report

Merging #249 into master will decrease coverage by 0.11%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #249      +/-   ##
==========================================
- Coverage   96.56%   96.45%   -0.12%     
==========================================
  Files          51       51              
  Lines         874      874              
  Branches       11       11              
==========================================
- Hits          844      843       -1     
- Misses         30       31       +1
Impacted Files Coverage Δ
...c/main/scala/frameless/TypedDatasetForwarded.scala 71.42% <0%> (-2.86%) ⬇️
...ataset/src/main/scala/frameless/TypedEncoder.scala 100% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 968492a...3d20c51. Read the comment docs.

@imarios
Copy link
Contributor Author

imarios commented Feb 13, 2018

Hey @OlivierBlanvillain! this will be the last PR in 0.5.0, do you have few minutes to give it a quick look?

@OlivierBlanvillain
Copy link
Contributor

:shipit: 👍

@imarios imarios merged commit 6aca77e into typelevel:master Feb 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants