Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SemigroupK instance for Xor + tests #996

Merged
merged 5 commits into from
Apr 27, 2016

Commits on Apr 24, 2016

  1. Add SemigroupK instance for Xor + tests

    Xor's SemigroupK instance follows that of XorT.
    aaron levin committed Apr 24, 2016
    Configuration menu
    Copy the full SHA
    63d186b View commit details
    Browse the repository at this point in the history

Commits on Apr 26, 2016

  1. XorT: remove MonoidK inst. + new SemigroupK inst.

    We remove the MonoidK instance as it depended on an not-well defined
    SemigroupK instance. The new SemigroupK instance places no constraints
    on `L`, and has a "first Right or Last Left" behaviour for combine. This
    has a closer semantic meaning to Xor(T)'s "success or failure"
    interpretation. It didn't make sense previously that the empty value for
    XortT's MonoidK instance represented failure
    (`XortT.left(F.pure(L.empty))(F)`). Why should every empty value signal
    failure?
    aaron levin committed Apr 26, 2016
    Configuration menu
    Copy the full SHA
    e66d238 View commit details
    Browse the repository at this point in the history
  2. Xor: SemigroupK w/ first-right,last-left semantics

    Update Xor's SemigroupK instance to be aligned with XorT's, with
    first-right, last-left semnatics.
    aaron levin committed Apr 26, 2016
    Configuration menu
    Copy the full SHA
    0bae0ca View commit details
    Browse the repository at this point in the history
  3. Remove implct Semigroup from Xor{T} SemigroupK tests

    aaron levin committed Apr 26, 2016
    Configuration menu
    Copy the full SHA
    8636343 View commit details
    Browse the repository at this point in the history
  4. Move Xor{T} SemigroupK tests into broader scope

    aaron levin committed Apr 26, 2016
    Configuration menu
    Copy the full SHA
    db83772 View commit details
    Browse the repository at this point in the history