Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move coverage away from bash #995

Merged
merged 1 commit into from Apr 25, 2016
Merged

Move coverage away from bash #995

merged 1 commit into from Apr 25, 2016

Conversation

ghost
Copy link

@ghost ghost commented Apr 24, 2016

Use new command in Travis for coverage, not the old "curl-and-bash" method.

see https://gitter.im/typelevel/cats?at=571ccb8dd47413c07dccc27c

@ghost
Copy link
Author

ghost commented Apr 24, 2016

This is failing as pip install is not run. I'm not sure why - perhaps as this is just a PR travis does not want to install this? The code is a straight copy from https://github.com/InTheNow/catalysts/blob/master/.travis.yml#L3-L4.

Also see https://libraries.io/pypi/codecov

@ceedubs
Copy link
Contributor

ceedubs commented Apr 25, 2016

@inthenow thanks! This looks like a big improvement. All of the other PR builds are currently failing as well, so I suspect this build failure isn't actually related to your change. The build logs don't exactly leave me enlightened as to what's going wrong.

To eliminate variables as we try to figure out what's going wrong with the build, we should probably hold off on merging this, but 👍 from me once we get things figured out.

Edit: I retract my statement about this failing in the same way as the other builds. I didn't notice the scripts/travis-publish.sh: line 35: codecov: command not found in the build logs. I was silly to think that @inthenow would have misdiagnosed a build failure :)

@ceedubs
Copy link
Contributor

ceedubs commented Apr 25, 2016

@inthenow do you think that the problem could be that we already have another install block here? I don't know yaml/travis all that well, but I'm wondering if the latter is overwriting your install block.

ceedubs added a commit to ceedubs/cats that referenced this pull request Apr 25, 2016
This is an experiment to test the theory stated in [this
comment](typelevel#995 (comment)).
@ceedubs ceedubs merged commit a6fe328 into typelevel:master Apr 25, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants