-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Eliminate the use of asInstanceOf in Eval. #924
Conversation
Current coverage is
|
@non If I recall, you put some effort into optimizing this. Any thoughts? |
Hey @TomasMikula! Sorry this has been hanging out so long. Do you have a sense of the relative performance before and after? I'll try to look at some benchmarks myself, but there could be a difference. The change to allow Let me know if you have some results to share, or if you are going to work on this. I'll try to get to it when I have some time to look into it (I may need similar benchmarks to continue working on #989). |
I haven't done any benchmarking. My primary goal was to get rid of |
OK thanks. I'll try to do some tests and comment here when I know more. |
I haven't done the benchmarking and don't anticipate doing it anytime soon. @TomasMikula I feel bad having your PR sitting here, and don't expect it to be merged soon. Would you mind if I closed it? I could open an issue encouraging us to investigate whether the casts are needed. |
No need to feel bad. I didn't anticipate there would be a performance concern when I opened the PR. |
scala/scala#6065 would make it possible to eliminate those |
No description provided.