Fix OptionIdOps.some to always return Some #873
Conversation
|
|
||
| test("OptionIdOps.some"){ | ||
| val s: String = null | ||
| s.some.contains(s) should === (true) |
There was a problem hiding this comment.
Due to NPE I wasn't able to write it as s.some should === (Some(null))
There was a problem hiding this comment.
Thanks, @vpavkin!
Would you mind leaving a comment in the code itself about why it's done this way?
Also, would you mind naming the test something that better identifies that it's checking for behavior when null is passed in? Maybe something like test(".some with null argument still results in Some #871").
There was a problem hiding this comment.
Looks like Option.contains isn't available on Scala 2.10
|
@ceedubs my bad. Added more comments and changed code to use |
Current coverage is
|
| @@ -76,4 +76,12 @@ class OptionTests extends CatsSuite { | |||
| isEq.lhs should === (isEq.rhs) | |||
| } | |||
| } | |||
|
|
|||
| // a test for OptionIdOps.some to return Some even if the argument is null | |||
There was a problem hiding this comment.
This comment probably isn't really needed since the test name says basically the same thing.
|
👍 thanks a bunch, @vpavkin! |
|
updated comment :) |
|
👍 |
Fix OptionIdOps.some to always return Some
Fix #871