Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link to actual Github Contributors #815

Closed
wants to merge 2 commits into from
Closed

Link to actual Github Contributors #815

wants to merge 2 commits into from

Conversation

raulraja
Copy link
Contributor

The following PR updates the AUTHORS file to include a link to the Github contributors list and charts which is automatically kept up to date.

@ceedubs @adelbertc @non Thanks for considering it.

@aryairani
Copy link
Contributor

I like the existing version better :-\ But maybe it's too much work to maintain?

@raulraja
Copy link
Contributor Author

For reference here is the link to the comment that triggered this PR https://gitter.im/non/cats?at=569afe4759e3d04215bc2fc4
I'm fine if folks would rather maintain a manual list though PR authors won't update it and the list will become obsolete in no time given the fast pace in which Cats is evolving.

@codecov-io
Copy link

Current coverage is 89.11%

Merging #815 into master will not affect coverage as of 0dc8f98

@@            master    #815   diff @@
======================================
  Files          168     168       
  Stmts         2306    2306       
  Branches        75      75       
  Methods          0       0       
======================================
  Hit           2055    2055       
  Partial          0       0       
  Missed         251     251       

Review entire Coverage Diff as of 0dc8f98

Powered by Codecov. Updated on successful CI builds.

@fthomas fthomas mentioned this pull request Jan 19, 2016
@ceedubs
Copy link
Contributor

ceedubs commented Jan 26, 2016

Thanks @raulraja. To me, there is some appeal of a manually curated list, because it seems more personal (I'm guessing this is where @refried is coming from). However, I do agree that it will constantly slip out of date, which is probably worse than not having the list at all. @non do you want to weigh in on this?

If we take this approach, what do you think about changing it to something like this?

Thank you to [the contributors](https://github.com/non/cats/graphs/contributors) whose work has made Cats possible

Also: this PR currently has a merge conflict.

@raulraja
Copy link
Contributor Author

@non @ceedubs I'm happy with a manual approach as well, just added this since it seem like people liked the way Ensime handled it but I understand that the link is a bit of indirection and not as personable. I'm gonna close sit since it looks like there are mixed feelings and people are not convinced this is what is best for Cats. Feel free to reopen or do whatever. Thanks for your consideration :)

@raulraja raulraja closed this Jan 26, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants