Add ApplicativeError #812
Merged
Add ApplicativeError #812
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is
|
|
Makes sense to me. Looks great! 👍 |
|
Awesome possum 👍 |
rtyley
added a commit
to scanamo/scanamo
that referenced
this pull request
Jul 23, 2024
The original implementation of the code to expose the `ConditionalCheckFailedException` was introduced with PR #212 in May 2018, but I'm not sure why the multi-line implementation was necessary - there's a discussion in PR #212, but I don't quite follow it: #212 (comment) The Cats `recover` functionality I'm using here was added with `ApplicativeError` in typelevel/cats#812 in January 2016, so it would have been available for PR #212. Perhaps it was some consequence of us being on AWS SDK v1 at that point, and having to use `AsyncHandler`? This implementation is definitely much more similar to ones we've used elsewhere, ie `ScalaFutureAdapter` and `PekkoInterpreter`. If we had a `ClassTag` we could go even smaller and use `attemptNarrow`, which was added to Cats with typelevel/cats#2863 in May 2019 - but even without that, the implementation is much smaller.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up to a question I asked on Gitter a few days ago.
The basic idea is that it seems useful to be able to abstract over
Validated[E, ?]as a context in which errors can be raised and handled, butValidatedisn't monadic, so we can't provide aMonadErrorinstance. None of theMonadErroroperations require monadic binding, though, and at least in the case ofValidated[E, ?]there are reasonable implementations. The onlyMonadErrorlaw we lose is the left zero law.This PR adds an
ApplicativeErrortype class aboveMonadError, together with laws forApplicativeErrorand an instance and tests forValidated. CurrentMonadErrorusage should be unaffected.