Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Topic/arrow scaladoc #797

Merged
merged 3 commits into from
Jan 13, 2016
Merged

Topic/arrow scaladoc #797

merged 3 commits into from
Jan 13, 2016

Conversation

lukewyman
Copy link
Contributor

Work for #788. Added Scaladoc comments for cats/arrow/Arrow.scala.

@erik-stripe
Copy link
Contributor

Looks great to me. 👍

I think that Travis error is spurious, we should retry it.

ceedubs
ceedubs reviewed Jan 12, 2016
View reviewed changes
core/src/main/scala/cats/arrow/Arrow.scala
def dimap[A, B, C, D](fab: F[A, B])(f: C => A)(g: B => D): F[C, D] =
compose(lift(g), andThen(lift(f), fab))

/**
* Create a new arrow that takes two inputs, but only modifies the second input
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo: only modifies the first input

@ceedubs
Copy link
Contributor

ceedubs commented Jan 12, 2016

Thanks, @lukewyman! Just one minor typo, and otherwise this looks great.

@codecov-io
Copy link

Current coverage is 88.36%

Merging #797 into master will increase coverage by +0.06% as of f8fdbc9

@@            master    #797   diff @@
======================================
  Files          166     166       
  Stmts         2291    2295     +4
  Branches        75      75       
  Methods          0       0       
======================================
+ Hit           2023    2028     +5
  Partial          0       0       
+ Missed         268     267     -1

Review entire Coverage Diff as of f8fdbc9

Powered by Codecov. Updated on successful CI builds.

@lukewyman
Copy link
Contributor Author

pushed a change to fix the typo on Arrow.first

@ceedubs
Copy link
Contributor

ceedubs commented Jan 13, 2016

Thanks! 👍

ceedubs added a commit that referenced this pull request Jan 13, 2016
@ceedubs
Merge pull request #797 from lukewyman/topic/arrow-scaladoc
591555f 
Topic/arrow scaladoc
@ceedubs ceedubs merged commit 591555f into typelevel:master Jan 13, 2016
@lukewyman lukewyman deleted the topic/arrow-scaladoc branch January 15, 2016 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lukewyman @erik-stripe @ceedubs @codecov-io