Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Eval instead of Trampoline for State #782

Merged
merged 2 commits into from
Jan 8, 2016
Merged

Use Eval instead of Trampoline for State #782

merged 2 commits into from
Jan 8, 2016

Commits on Jan 7, 2016

  1. Use Eval instead of Trampoline for State 

    This may provide the following benefits:

1) It should be a bit more efficient.
2) It removes the need to `import cats.std.function._` for some
operations, which may make it a bit more newcomer friendly.
3) We are already using Eval for things like foldRight, so it seems more
consistent to use it for `State`.
4) I think it's a bit easier to explain `Eval` than `Trampoline`, since
it's hard to explain the latter without first explaining `Free`. So
again, this may be a bit more newcomer friendly.
    @ceedubs
    ceedubs committed Jan 7, 2016
    Configuration menu
    Copy the full SHA
    81a24d9 View commit details
    Browse the repository at this point in the history

  2. Remove unused specialized State instance

    @ceedubs
    ceedubs committed Jan 7, 2016
    Configuration menu
    Copy the full SHA
    d338150 View commit details
    Browse the repository at this point in the history