Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds Show[Vector] #774

Merged
merged 1 commit into from
Jan 5, 2016
Merged

Adds Show[Vector] #774

merged 1 commit into from
Jan 5, 2016

Conversation

mikejcurry
Copy link
Contributor

Adds a Show instance for Vector.

@codecov-io
Copy link

Current coverage is 88.49%

Merging #774 into master will increase coverage by +0.01% as of 5e9a899

@@            master    #774   diff @@
======================================
  Files          166     166       
  Stmts         2283    2285     +2
  Branches        74      74       
  Methods          0       0       
======================================
+ Hit           2020    2022     +2
  Partial          0       0       
  Missed         263     263

Review entire Coverage Diff as of 5e9a899

Powered by Codecov. Updated on successful CI builds.

@non
Copy link
Contributor

non commented Jan 4, 2016

👍 Thanks!

ceedubs
ceedubs reviewed Jan 5, 2016
View reviewed changes
core/src/main/scala/cats/std/vector.scala
@@ -43,6 +44,11 @@ trait VectorInstances {
Streaming.fromVector(fa)
}

implicit def vectorShow[A:Show]: Show[Vector[A]] =
new Show[Vector[A]] {
def show(fa: Vector[A]): String = fa.map(_.show).mkString("Vector(", ", ", ")")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same question as here

@ceedubs
Copy link
Contributor

ceedubs commented Jan 5, 2016

I'm going to go ahead and merge. This is a useful instance and we can always revisit the syntax usage later.

ceedubs added a commit that referenced this pull request Jan 5, 2016
@ceedubs
Merge pull request #774 from mikejcurry/add-vector-show
cb2a945 
Adds Show[Vector]
@ceedubs ceedubs merged commit cb2a945 into typelevel:master Jan 5, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mikejcurry @codecov-io @non @ceedubs