Remove unused Cokleisli.cokleisli method

[ceedubs]

This method currently isn't used. Since Cokleisli is already a case
class with an equivalent auto-generated apply method, I don't think I
see the usefulness of it. Feel free to let me know if you would prefer
to keep this around.

[codecov-io]

Current coverage is 88.51%

Merging #752 into master will increase coverage by +1.29% as of b740783

@@            master    #752   diff @@
======================================
  Files          166     166       
  Stmts         2293    2289     -4
  Branches        74      74       
  Methods          0       0       
======================================
+ Hit           2000    2026    +26
  Partial          0       0       
+ Missed         293     263    -30

Review entire Coverage Diff as of b740783

Powered by Codecov. Updated on successful CI builds.

[stew]

👍

[fthomas]

@ceedubs There is a similar function for Kleisli called function. Do you also want to remove that?

[adelbertc]

👍

@fthomas I believe the existence of Kleisli.function is in part due to me - due to our ReaderT alias, it may make readability strange to see ReaderT.kleisli. Though as I type this I wonder if the auto-generated Kleisli.apply will also be useable from the value alias we have..

Does appear to:

scala> import cats.data._
import cats.data._

scala> Kleisli((x: Int) => Option(x))
res0: cats.data.Kleisli[Option,Int,Int] = Kleisli(<function1>)

scala> ReaderT((x: Int) => Option(x))
res1: cats.data.Kleisli[Option,Int,Int] = Kleisli(<function1>)

So yeah we can remove Kleisli.function

[fthomas]

I would be surprised if ReaderT(f) would not be the same as Kleisli(f) or Kleisli.function(f).

[ceedubs]

@adelbertc @fthomas I removed Kleisli.function as well.

[adelbertc]

👍