Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds Monoid instance for Validated #715

Merged
merged 1 commit into from
Dec 6, 2015

Conversation

mikejcurry
Copy link
Contributor

Adds a Monoid instance for Validated

@codecov-io
Copy link

Current coverage is 85.45%

Merging #715 into master will increase coverage by +0.03% as of 1faff73

@@            master    #715   diff @@
======================================
  Files          162     162       
  Stmts         2230    2234     +4
  Branches        74      74       
  Methods          0       0       
======================================
+ Hit           1905    1909     +4
  Partial          0       0       
  Missed         325     325       

Review entire Coverage Diff as of 1faff73

Powered by Codecov. Updated on successful CI builds.

@adelbertc
Copy link
Contributor

👍

@ceedubs
Copy link
Contributor

ceedubs commented Dec 6, 2015

👍 thanks!

It would also be nice to have a Semigroup instance if B has a Semigroup but not a Monoid.

ceedubs added a commit that referenced this pull request Dec 6, 2015
Adds Monoid instance for Validated
@ceedubs ceedubs merged commit 48c38e5 into typelevel:master Dec 6, 2015
mikejcurry referenced this pull request in mikejcurry/cats Dec 6, 2015
@mikejcurry mikejcurry deleted the validated-monoid branch December 11, 2015 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants