Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move NaturalTransformation.or from companion to trait #697

Merged
merged 2 commits into from
Nov 25, 2015

Conversation

ceedubs
Copy link
Contributor

@ceedubs ceedubs commented Nov 23, 2015

I think this provides slightly nicer syntax for combining natural
transformations, and it makes it more consistent with andThen and
compose. If people like it, they can merge, but if not it's no
problem.

I think this provides slightly nicer syntax for combining natural
transformations, and it makes it more consistent with `andThen` and
`compose`. If people like it, they can merge, but if not it's no
problem.
@ceedubs
Copy link
Contributor Author

ceedubs commented Nov 23, 2015

@raulraja as the original contributor of or, what do you think?

@raulraja
Copy link
Contributor

LGTM! Also or as infix in the examples looks so much cleaner

@codecov-io
Copy link

Current coverage is 83.89%

Merging #697 into master will not affect coverage as of 9ceaef6

@@            master    #697   diff @@
======================================
  Files          162     162       
  Stmts         2217    2217       
  Branches        74      74       
  Methods          0       0       
======================================
  Hit           1860    1860       
  Partial          0       0       
  Missed         357     357       

Review entire Coverage Diff as of 9ceaef6

Powered by Codecov. Updated on successful CI builds.

@lvicentesanchez
Copy link

I like it. That would help me to get rid of my own implicit/explicit or that I use to combine more than 2 NT.

@non
Copy link
Contributor

non commented Nov 24, 2015

👍

1 similar comment
@adelbertc
Copy link
Contributor

👍

adelbertc added a commit that referenced this pull request Nov 25, 2015
Move NaturalTransformation.or from companion to trait
@adelbertc adelbertc merged commit efe4af7 into typelevel:master Nov 25, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants