Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comment out unused XorTMonadCombine #687

Merged
merged 1 commit into from
Dec 1, 2015

Conversation

ceedubs
Copy link
Contributor

@ceedubs ceedubs commented Nov 20, 2015

This trait is currently unused, because the implicit def that uses it is
commented out until we have separated weak/strong laws for MonadCombine. We probably shouldn't expose it if it doesn't satisfy our current MonadCombine laws.

This trait is currently unused, because the implicit def that uses it is
commented out until we have separated weak/strong laws for `MonadCombine`. We probably shouldn't expose it if it doesn't satisfy our current `MonadCombine` laws.
@codecov-io
Copy link

Current coverage is 83.76%

Merging #687 into master will not affect coverage as of 7a737fe

@@            master    #687   diff @@
======================================
  Files          162     162       
  Stmts         2217    2217       
  Branches        74      74       
  Methods          0       0       
======================================
  Hit           1857    1857       
  Partial          0       0       
  Missed         360     360       

Review entire Coverage Diff as of 7a737fe

Powered by Codecov. Updated on successful CI builds.

@non
Copy link
Contributor

non commented Nov 20, 2015

👍

@adelbertc
Copy link
Contributor

👍

adelbertc added a commit that referenced this pull request Dec 1, 2015
Comment out unused XorTMonadCombine
@adelbertc adelbertc merged commit 399f645 into typelevel:master Dec 1, 2015
@ceedubs ceedubs deleted the rm-xortmonadcombine branch December 1, 2015 04:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants