Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add WriterT Bifunctor #673

Merged
merged 2 commits into from
Nov 19, 2015
Merged

Add WriterT Bifunctor #673

merged 2 commits into from
Nov 19, 2015

Conversation

ceedubs
Copy link
Contributor

@ceedubs ceedubs commented Nov 18, 2015

Knocks one item off of the checklist on #620.

@ceedubs
Add WriterT Bifunctor
31d86c3 
Knocks one item off of the checklist on typelevel#620.
@ceedubs ceedubs mentioned this pull request Nov 18, 2015
Closed
19 tasks
@codecov-io
Copy link

Current coverage is 82.85%

Merging #673 into master will increase coverage by +1.39% as of 5d0bde0

@@            master    #673   diff @@
======================================
  Files          159     162     +3
  Stmts         2131    2217    +86
  Branches        72      74     +2
  Methods          0       0       
======================================
+ Hit           1736    1837   +101
  Partial          0       0       
+ Missed         395     380    -15

Review entire Coverage Diff as of 5d0bde0

Powered by Codecov. Updated on successful CI builds.

adelbertc
adelbertc reviewed Nov 19, 2015
View reviewed changes
core/src/main/scala/cats/data/WriterT.scala
@@ -1,6 +1,8 @@
package cats
package data

import functor.Bifunctor
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nitpicking, but given we seem to use the fully qualified name in other imports, maybe import cats.functor.Bifunctor

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like your style. Will do.

@adelbertc
Copy link
Contributor

👍

@fthomas
Copy link
Member

fthomas commented Nov 19, 2015

👍

fthomas added a commit that referenced this pull request Nov 19, 2015
@fthomas
Merge pull request #673 from ceedubs/writert-bifunctor
e87df11 
Add WriterT Bifunctor
@fthomas fthomas merged commit e87df11 into typelevel:master Nov 19, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ceedubs @codecov-io @adelbertc @fthomas