Fix Streaming#memoization. #665
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes a bug noticed by @ceedubs. The basic issue is that we have to be sure to memoize the Eval instance holding the tail while *also* memoizing the tail itself when it is calculated. Previously we were only memoizing the head node.
| * There are two calls to memoized here -- one is a recursive call | ||
| * to this method (on the tail) and the other is a call to memoize | ||
| * the Eval instance holding the tail. For more information on how | ||
| * .memoize works see Eval#memoize. |
There was a problem hiding this comment.
Minor: could we turn this into a proper ScalaDoc link? [[cats.Eval.memoize]]
|
This fixes (and replaces) #662. I left a minor request about the ScalaDoc, but 👍 from me (assuming the build passes). |
Current coverage is
|
| } | ||
|
|
||
| // convert List[A] to Streaming[A] | ||
| def convert[A](as: List[A]): Streaming[A] = |
There was a problem hiding this comment.
Is this used anywhere, or just added for possible future use?
There was a problem hiding this comment.
Oh, looks like I left that in. I'll remove it.
|
👍 once question about function is answered :-) |
|
Strange error, rebuilding, once it's green 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes a bug noticed by @ceedubs. The basic issue
is that we have to be sure to memoize the Eval instance holding
the tail while also memoizing the tail itself when it is
calculated. Previously we were only memoizing the head node.